-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix error message upon misalignment in PadDynamicalDecoupling
#12952
Conversation
One or more of the following people are relevant to this code:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my understanding: is the expectation that the (correct) error message should only show if there's been a bug in the prior PadDelay
pass, or are we expecting users to feed in manually scheduled circuits?
releasenotes/notes/fix-dd-misalignment-msg-76fe16e5eb4ae670.yaml
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 10384311178Details
💛 - Coveralls |
As I understand it, this error message should only come up if users put manual delays into the circuit and either didn't run |
* Fix misalignment msg * slightly better formatting * typo (cherry picked from commit 9252713)
Summary
If a delay is misaligned and following a
DAGInNode
(or preceding aDAGOutNode
), the error message inPadDynamicalDecoupling
previously failed, as it was trying to access non-existing attributes. This is because, unlikeDAGOpNode
, the in and out nodes do not have aname
orqargs
attribute.