Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Binary arithmetic gates #13354

Merged
merged 17 commits into from
Nov 6, 2024
Merged

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Oct 22, 2024

Summary

Part of #13046: gate representations & plugins for the binary arithmetic operations (adder and multiplier).

@Cryoris Cryoris added this to the 1.3.0 milestone Oct 22, 2024
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@coveralls
Copy link

coveralls commented Oct 25, 2024

Pull Request Test Coverage Report for Build 11707625761

Details

  • 298 of 327 (91.13%) changed or added relevant lines in 17 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 88.786%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/synthesis/arithmetic/adders/draper_qft_adder.py 25 26 96.15%
qiskit/synthesis/arithmetic/multipliers/hrs_cumulative_multiplier.py 24 26 92.31%
qiskit/synthesis/arithmetic/multipliers/rg_qft_multiplier.py 22 24 91.67%
qiskit/circuit/library/arithmetic/adders/adder.py 28 31 90.32%
qiskit/circuit/library/arithmetic/multipliers/multiplier.py 18 21 85.71%
qiskit/transpiler/passes/synthesis/hls_plugins.py 61 79 77.22%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 92.73%
Totals Coverage Status
Change from base Build 11706516151: -0.003%
Covered Lines: 77319
Relevant Lines: 87085

💛 - Coveralls

and not imagine new classes that dont exist
@Cryoris Cryoris added the Changelog: New Feature Include in the "Added" section of the changelog label Oct 29, 2024
Copy link
Contributor

@alexanderivrii alexanderivrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this PR. I have left several comments in-place.

Now the follow-up step is to port the synthesis functions to Rust :).

Copy link
Contributor

@alexanderivrii alexanderivrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all these changes!

@alexanderivrii alexanderivrii added this pull request to the merge queue Nov 6, 2024
Merged via the queue into Qiskit:main with commit 50217b6 Nov 6, 2024
17 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog synthesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants