-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Binary arithmetic gates #13354
Binary arithmetic gates #13354
Conversation
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 11707625761Details
💛 - Coveralls |
and not imagine new classes that dont exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this PR. I have left several comments in-place.
Now the follow-up step is to port the synthesis functions to Rust :).
qiskit/synthesis/arithmetic/multipliers/hrs_cumulative_multiplier.py
Outdated
Show resolved
Hide resolved
…ra into clib/binaryarithmetic
…ra into clib/binaryarithmetic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making all these changes!
Summary
Part of #13046: gate representations & plugins for the binary arithmetic operations (adder and multiplier).