Fix .decompose on control flow
#13545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
Cryoris
added
stable backport potential
This was
linked to
issues
Dec 10, 2024
ElePT
reviewed
Dec 10, 2024
| @@ -58,20 +60,28 @@ def run(self, dag: DAGCircuit) -> DAGCircuit: | |||
| output dag where ``gate`` was expanded. | |||
| """ | |||
| # We might use HLS to synthesize objects that do not have a definition | |||
| hls = HighLevelSynthesis() if self.apply_synthesis else None | |||
| hls = HighLevelSynthesis(qubits_initially_zero=False) if self.apply_synthesis else None | |||
There was a problem hiding this comment.
Was this a previous oversight?
There was a problem hiding this comment.
Yeah, we should not assume the initial qubit state since HLS here is called on individual blocks inside the circuit. However, technically, it didn't really matter since this argument only makes a difference if there are auxiliary qubits involved and the way we build the node_as_dag here won't have any auxiliary qubits. But still it's likely better to have the correct setting here 🙂
Pull Request Test Coverage Report for Build 12256626824Details
💛 - Coveralls |
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
ElePT
approved these changes
Dec 10, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
* decompose control flow ops * add reno and test * trailing print * thou shall support Python 3.9 * Fix comments & reno Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> --------- Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> (cherry picked from commit 4495c67)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
* decompose control flow ops * add reno and test * trailing print * thou shall support Python 3.9 * Fix comments & reno Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> --------- Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> (cherry picked from commit 4495c67) Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two behaviors when decomposing control flow:
c_ifon an operation without definition (i.e.None) would failQuantumCircuit.decomposeraises an error with a conditional U gate for Qiskit 1.3.0 and the main branch #13493).decompose(Control flow operations are not.decomposed #13544)Details and comments
Even though
c_ifis deprecated we should still handle this case, but the logic for this can be removed oncec_ifis gone. There's a comment specifying which part isc_if-specific.