Reduce non-determinism in UnitarySynthesis pass
#13667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
ElePT
changed the title
UnitarySythesis passUnitarySynthesis pass
Pull Request Test Coverage Report for Build 12785721816Details
💛 - Coveralls |
ElePT
changed the title
UnitarySynthesis passUnitarySynthesis pass
ShellyGarion
approved these changes
Jan 15, 2025
mtreinish
reviewed
Jan 15, 2025
| @@ -627,8 +627,8 @@ fn get_2q_decomposers_from_target( | |||
| } | |||
|
|
|||
| let target_basis_set = get_target_basis_set(target, qubits[0]); | |||
| let available_1q_basis: HashSet<&str> = | |||
| HashSet::from_iter(target_basis_set.get_bases().map(|basis| basis.as_str())); | |||
| let available_1q_basis: IndexSet<&str> = | |||
There was a problem hiding this comment.
You should use use the ahash hasher here otherwise this will cause a slowdown on lookups in the hash set.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes the use of an
IndexMapin the Rust implementation ofUnitarySynthesisto allow for a more deterministic output of the pass, and to ensure that the Python and Rust codes produce the same outputs when facing the same inputs. While this is not a guarantee we make, I believe it is good to have, makes testing much easier, and will smoothen the path for the transition to always using the target as a transpilation constraint "vehicle" (this PR fixes an issue found in a test in #12850).Details and comments