-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bump rand
to 0.9 and associated crates
#13806
Conversation
This is a breaking API change, but our exposure is mostly just to some minor renames. Unfortunately the whole ecosystem hasn't migrated yet, so we're still compiling in multiple versions of `rand`, but with any luck, bumping hashbrown and dropping faer will help.
One or more of the following people are relevant to this code:
|
Oh ugh, looks like some of the seeding behaviour has changed as well. |
Scanning through the changes to the pRNG we use between 0.8.5 and 0.9.0, and to the implementation of the standard uniform distribution, it doesn't look like we should have seen randomisation changes, which makes me a bit nervous. I wasn't expecting to see any - the mathematics of what makes up the pcg64_fast pRNG are fixed, and the internal seed mixing of those hasn't changed. That said, running the tests locally several times shows that the randomness changes appear deterministic, so the chances are it's something I'm just missing in understanding. I'll push up the test changes to fix the random-seeded tests. |
Pull Request Test Coverage Report for Build 13330455581Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the sabre test file conflict this LGTM, I'll reapprove it once it's rebased. That being said I'm going to miss the from_entropy()
function. I liked that name more.
Conflict should be resolved. |
Summary
This is a breaking API change, but our exposure is mostly just to some minor renames. Unfortunately the whole ecosystem hasn't migrated yet, so we're still compiling in multiple versions of
rand
, but with any luck, bumping hashbrown and dropping faer will help.Details and comments
This obsoletes the three separate PRs that dependabot is trying to make (and keeps trying to jam up CI with):
Close #13745
Close #13746
Close #13747