Warn on use of property_set kwarg to BasePassManger.run
#13821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transpiler's `BasePass.__call__` implementation accepts a `property_set` kwarg that can be used to seed the property set for the run of that pass. Starting in Qiskit 2.0, `PassManager.run` will also have that behaviour, so this commit begins emitting a warning on the potential change. The impact of this is expected to be minimal, as we are not aware of much use of the subclassing of the generic `BasePassManager`, and even less of passing arbitrary keyword arguments to the conversion functions.
jakelishman
added
Changelog: API Change
|
One or more of the following people are relevant to this code:
|
ElePT
reviewed
Feb 14, 2025
releasenotes/notes/passmanager-run-property_set-cb19ce448ab1e93a.yaml
Outdated
Show resolved
Hide resolved
ElePT
previously approved these changes
Feb 14, 2025
ElePT
reviewed
Feb 14, 2025
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transpiler's
BasePass.__call__implementation accepts aproperty_setkwarg that can be used to seed the property set for the run of that pass. Starting in Qiskit 2.0,PassManager.runwill also have that behaviour, so this commit begins emitting a warning on the potential change.The impact of this is expected to be minimal, as we are not aware of much use of the subclassing of the generic
BasePassManager, and even less of passing arbitrary keyword arguments to the conversion functions.Summary
Details and comments
This is the warning to enable to API change of #13820.