Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The unused parameter dag in DAGNode constructor is removed #13863

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Feb 17, 2025

Summary

Removal of the deprecation from #13862 . Therefore, on hold until the deprecation is merged in 1.4

@1ucian0 1ucian0 requested a review from a team as a code owner February 17, 2025 17:06
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

1ucian0 and others added 2 commits February 17, 2025 19:13
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@1ucian0 1ucian0 added this to the 2.0.0 milestone Feb 17, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13376405668

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 111 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.06%) to 88.198%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/two_qubit_decompose.rs 1 91.82%
crates/qasm2/src/expr.rs 1 94.23%
crates/circuit/src/dag_node.rs 3 76.52%
crates/qasm2/src/lex.rs 5 92.48%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 47 74.05%
crates/accelerate/src/unitary_synthesis.rs 54 94.29%
Totals Coverage Status
Change from base Build 13336190323: -0.06%
Covered Lines: 78751
Relevant Lines: 89289

💛 - Coveralls

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants