Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove deprecated legacy scheduling passes #13876

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

mtreinish
Copy link
Member

Summary

This commit removes the deprecated legacy scheduling passes. These passes were replaced by the new scheduling passes a long time ago and finally marked as deprecated in 1.1.0. This commit follows through on the promise of that deprecation and removes the passes marked as deprecated.

Details and comments

This commit removes the deprecated legacy scheduling passes. These
passes were replaced by the new scheduling passes a long time ago and
finally marked as deprecated in 1.1.0. This commit follows through on
the promise of that deprecation and removes the passes marked as
deprecated.
@mtreinish mtreinish added the Changelog: Removal Include in the Removed section of the changelog label Feb 18, 2025
@mtreinish mtreinish added this to the 2.0.0 milestone Feb 18, 2025
@mtreinish mtreinish requested a review from a team as a code owner February 18, 2025 22:30
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @nkanazawa1989

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13401250824

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.008%) to 88.112%

Files with Coverage Reduction New Missed Lines %
crates/circuit/src/dag_circuit.rs 1 87.6%
crates/circuit/src/operations.rs 1 88.45%
crates/qasm2/src/lex.rs 3 92.98%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 13397495918: 0.008%
Covered Lines: 78280
Relevant Lines: 88841

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wish I had remembered the incoming removal before working on #13805, but well, the conflict resolution should be easy.

@ElePT ElePT added this pull request to the merge queue Feb 19, 2025
Merged via the queue into Qiskit:main with commit bd30693 Feb 19, 2025
17 checks passed
@mtreinish mtreinish deleted the drop-legacy_sched_pass branch February 19, 2025 11:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants