Parse passwords with special chars correctly #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepoviola
approved these changes
Jan 13, 2024
|
+1 Thank you for proposing this PR @pm-trey. My use case involves AWS RDS IAM authentication against postgres, and special characters in the password has been the limiting factor. |
|
Ping @evoxmusic, I thinks this is a good one to merge. |
|
@pepoviola just wondering when this one will be merged? |
|
Ping @evoxmusic, can you merge this one? Thanks!! |
evoxmusic
approved these changes
May 4, 2024
|
Thank you @evoxmusic @pepoviola |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Could not connect to Postgresql DBs using passwords with special characters.
Fix:
Implement url decoding for password passed to Postgresql config
Tests:
Passing