Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement Validation for SecurityType Symbol #5

Merged

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented Feb 9, 2024

Description

  • Implement validation of ticker SecurityType, because the current version supports only Equity type.
  • Introduces two new private boolean fields to the codebase. These flags are designed to track warning states within the application, enhancing overall code clarity and maintainability.
  • Remove not support Symbol's SecurityType from Readme

Related Issue

N/A

Motivation and Context

To enhance user experience and make the system more user-friendly, this pull request aims to implement validation for the SecurityType ticker. Currently, only Equity type tickers are supported, and implementing validation will ensure that users are informed and guided appropriately when entering ticker information. This will ultimately improve the overall usability and reliability of the system.

Requires Documentation Change

N/A

How Has This Been Tested?

Add severl test case to check it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Martin-Molinero Martin-Molinero merged commit 3fed7cc into QuantConnect:master Feb 9, 2024
@Romazes Romazes deleted the feature-validation-security-type branch March 18, 2024 22:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants