Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Problems with fetch_nb_dependency #278

Closed
cc7768 opened this issue Jan 11, 2017 · 3 comments
Closed

Problems with fetch_nb_dependency #278

cc7768 opened this issue Jan 11, 2017 · 3 comments

Comments

@cc7768
Copy link
Member

cc7768 commented Jan 11, 2017

@thomassargent30 was trying to download files from QuantEcon.applications and the current dependency fetcher doesn't seem to be able to do this easily.

It might be useful to do the following two things:

  • Currently, the function takes a deps argument because it helps you get to the dependency folder of QuantEcon.Notebooks. In line 73 of the function it joins the repo, raw, deps, and other arguments together. It might make sense to remove the deps argument altogether (or rename it to be folder) and just require people to use the dictionary approach when getting files from QuantEcon.Applications... There could be a few other possible solutions to this, but I think the current design prevents the code from being able to fetch files from other repositories (which I think was one of the goals).
  • Write some examples of how this function works.

Both of these seem like relatively easy tasks? Do we have any newer members of the team that might be capable of doing this?

Maybe @mmcky has some design thoughts to fix this?

@oyamad
Copy link
Member

oyamad commented Jan 11, 2017

I agree deps will better be folder, or directory.

A use case is found in Cell [44] in here.

@mmcky
Copy link
Contributor

mmcky commented Feb 23, 2017

Only thing left is to:

  • Write some examples of how this function works.

@mmcky
Copy link
Contributor

mmcky commented Oct 19, 2017

Closing based on PR #279 and #320

@mmcky mmcky closed this as completed Oct 19, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants