Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add some examples for the documentation on the nb_fetch utility #320

Merged
merged 1 commit into from
Aug 4, 2017

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Aug 3, 2017

this addresses issue #278.

When writing this, the default values set for this utility are probably no longer appropriate with the development of QuantEconLib. I propose to remove these defaults to make this utility a bit more general as a simple way of fetching files from a Github repo.

REPO = "https://github.com/QuantEcon/QuantEcon.notebooks"
RAW = "raw"
BRANCH = "master"
FOLDER = "dependencies"          #Hard Coded Dependencies Folder on QuantEcon.notebooks

@mmcky mmcky added the discuss label Aug 3, 2017
@mmcky mmcky requested a review from cc7768 August 3, 2017 06:49
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.124% when pulling 483df52 on update-fetch-utility into a82ba69 on master.

@mmcky
Copy link
Contributor Author

mmcky commented Aug 4, 2017

@cc7768 I am going to merge this PR. Let me know if you think the examples need to be updated and we can do so.

@mmcky mmcky merged commit 08e634a into master Aug 4, 2017
@mmcky mmcky deleted the update-fetch-utility branch August 4, 2017 01:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants