-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use embed mode #61
Comments
There's a lot to like about pushing the whole "app" over into an iframe. We'd the benefit of the engineering they put in to make a robust integration layer. And if this package grew a mimerenderer, it would be a much cleaner way to not have things fight with each other. However, and not to derail the conversation too much: I think there's a lot more to investigate in mxgraph integration. For example, the ports example shows HTML embedded directly inside a block. I haven't tried it, but if the contract is "give me a dom node", I could imagine dragging a codemirror from a notebook into an mxgraph shape with control flow ports and suddenly having an extremely interesting UI. It can also do collapsing, and level-of-detail, which seem very interesting. The other thing it could probably handle would be a document layout tool for posters and (since newer versions support/expose multiple pages) presentations: again, assuming it can put "hot" lumino widgets into its tree, this would allow a level of control not currently available in any notebook UI I've seen, without relying on (but also not excluding) css. Anyhow, these should likely be investigated in another extension altogether! |
Sooo.... I took a stroll down this path... https://github.com/bollwyvl/jupyterlab-drawio/tree/add-drawio-embed-mode ...but it's basically unreviewable, and very possibly unmergeable. In a nutshell:
Happy to discuss what of this could make it upstream! Of course, I still want to actually play with reversing the embedding pattern, and being able to put jupyter cells inside mxgraph geometry, but frankly my need is greater for this piece. Some other really neat things thought about while doing this hack:
|
I think we don't use the standardized messaging protocol this library provides for embedding in other applications, to make the save menus seamless, etc. It would be great to look into using the embed mode: https://desk.draw.io/support/solutions/articles/16000042544-embed-mode
The text was updated successfully, but these errors were encountered: