Fix nightly 2.0 #720
Merged
Fix nightly 2.0 #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcAntoineSchmidtQC
requested review from
xhochy,
jtilly and
lbittarello
as code owners
| echo "Installing $pkg nightly" | ||
| micromamba remove -y --force $pkg | ||
| pip install --pre --no-deps --only-binary :all: --upgrade --timeout=60 -i $PRE_WHEELS $pkg | ||
| done | ||
| echo Install pyarrow nightly | ||
| micromamba remove -y --force pyarrow | ||
| pip install --extra-index-url https://pypi.fury.io/arrow-nightlies/ --prefer-binary --pre --no-deps pyarrow |
There was a problem hiding this comment.
| np.log(min_alpha), | ||
| self.n_alphas, | ||
| base=np.e, | ||
| dtype=X.dtype, |
There was a problem hiding this comment.
Added the dtype here. It was causing issues with 32-bit runs because the alphas were set to be 64 bits, and this would upcast downstream variables when multiplying, causing typing issues with our C++ code.
| @@ -1631,7 +1635,7 @@ def _wald_test_matrix( | |||
| # We want to calculate Rb_r^T (RVR)^{-1} Rb_r. | |||
| # We can do it in a more numerically stable way by using `scipy.linalg.solve`: | |||
| try: | |||
| test_stat = float(Rb_r.T @ linalg.solve(RVR, Rb_r)) | |||
There was a problem hiding this comment.
not allowed anymore with numpy 2.0
jtilly
approved these changes
Oct 30, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing glum to support numpy 2.0. Here is a summary of the changes:
np.Inf->np.infChecklist
CHANGELOG.rstentry