Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FEN, PGN and arena adjustments for Chess960 #129

Merged
merged 5 commits into from
Jun 8, 2021

Conversation

magehrke
Copy link
Contributor

@magehrke magehrke commented Jun 8, 2021

Small fixes for chess960:

  • Adding fens for arena games in RL
  • Adding correctly pgn printing for castling in chess960
  • In arena mode, each opening is now played twice, where player are switched after each game.

@QueensGambit Please have a look at the last commit. You said you wanted some changes regarding the usage of pointers?! Please let me know what I can do.

@magehrke magehrke changed the title Chess960 FEN, PGN and arena mode adjustments for Chess960 Jun 8, 2021
@magehrke magehrke changed the title FEN, PGN and arena mode adjustments for Chess960 FEN, PGN and arena adjustments for Chess960 Jun 8, 2021
@QueensGambit
Copy link
Owner

QueensGambit commented Jun 8, 2021

Thank you for the update.
I changed fen to be a const string& datatype.
I think this makes the code easier to read and avoids an additional return parameter.

@QueensGambit QueensGambit merged commit b95a8bf into QueensGambit:master Jun 8, 2021
@magehrke magehrke deleted the chess960 branch June 8, 2021 13:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants