Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RL Logging: Found tablebases and Configs 2.0 #132

Merged
merged 4 commits into from
Jun 8, 2021

Conversation

magehrke
Copy link
Contributor

@magehrke magehrke commented Jun 8, 2021

  • Adds a logging statement with the number of found tablebases
  • Changes logging of config files to increase readability

An example logging output is shown on the following image:

image

@QueensGambit
Copy link
Owner

For the record, this PR resolves the code review from #130.

@magehrke
Copy link
Contributor Author

magehrke commented Jun 8, 2021

Note: The number of lines that the for loop iterates has to be quite big as the output from the subprocess gets buffered. For every option that we have set so far, we get at least one return statement. And because CrazyAra has a lot of UCI options that will be set (roughly 50), I think 200 is a good upper bound.

@QueensGambit
Copy link
Owner

Sounds reasonable.

@QueensGambit QueensGambit merged commit 0067816 into QueensGambit:master Jun 8, 2021
@magehrke magehrke deleted the logging branch June 8, 2021 14:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants