-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add a Open_Spiel Stratego implementation as well adapting MCTSAgent by defining different types of it #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e stratego needs another board
…e stratego needs another board - this time correct
…e stratego needs another board
…e stratego needs another board - this time correct
BluemlJ
commented
Jul 12, 2021
BluemlJ
commented
Jul 12, 2021
BluemlJ
commented
Jul 12, 2021
BluemlJ
commented
Jul 12, 2021
Remove static numberofgames from arena modes and add it to the inputstring
Remove unnecessary code
Remove blank lines
BluemlJ
commented
Jul 12, 2021
BluemlJ
commented
Jul 12, 2021
Add some comments to the alternative arena methods : mctsarena, mctstournament and evaltournament
BluemlJ
commented
Jul 12, 2021
remove blank line
BluemlJ
commented
Jul 12, 2021
BluemlJ
commented
Jul 12, 2021
Remove the code to print InformationStateTensors as a debugging feature.
BluemlJ
commented
Jul 12, 2021
QueensGambit
approved these changes
Jul 12, 2021
changed constats to return uint instead of int
reduced scope of bestMoveIdx
removed unused shape removed unnecessary assignment
removed unused variable fen2
avoid reassigning a value before the old one has been used
pass string by const reference
pass string by const reference
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request, I add an interface to CrazyAra which enables the use of my own Stratego implementation which is based on Open_Spiel. This PR adds two major extensions to CrazyAra:
First the extension of a Stratego environment:
The interface is based on a new state (engine/src/environments/stratego_related/), based on the existing interface for open_spiel games. It also adds my own fork of open_spiel as a submodule because it is not merged with the official open_spiel project yet. (.gitmodules)
To use CrazyAra for Stratego a new game mode called MODE_STRATEGO is added to all necessary files as well as the CMakeList:
It is compatible with the Profiling modes as well as the RL mode and is tested with the TensorRT backend.
A building test was also added to the GitHub workflow as well as the possiblity to start the variants workflow out of Github to make testing easier (variants.yml).
The second extension was the addition of MCTSAgent Types. In my thesis, I tested different agent types on imperfect information games. For this, I added new agents which inherit the basic MCTSAgent
I also adapted MCTSAgent for this and added some specific handling for Stratego (like playing starting positions twice with alternating colors). I also added three new modes which are currently only tested on Stratego to run comparisons between different MCTSAgent types and models more easily, directly on the console without using additional software.
I also added a Dockerfile for Stratego which extends the current docker file by installing open_spiel and the dependencies.
(engine/src/rl/Dockerfile_Stratego)