Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BREAKING] Use FloatingPoint protocol in beCloseTo matcher #879

Merged
merged 1 commit into from
May 9, 2021

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented May 8, 2021

Resolves #394.

@ikesyo ikesyo force-pushed the becloseto-with-floatingpoint-protocol branch from c23b3af to 344fabb Compare May 8, 2021 15:39
@ikesyo ikesyo added this to the v10 milestone May 8, 2021
@ikesyo ikesyo force-pushed the becloseto-with-floatingpoint-protocol branch from 344fabb to b8220ff Compare May 9, 2021 00:39
@ikesyo ikesyo changed the title WIP: Use FloatingPoint protocol in beCloseTo matcher [BREAKING] Use FloatingPoint protocol in beCloseTo matcher May 9, 2021
@ikesyo ikesyo force-pushed the becloseto-with-floatingpoint-protocol branch from b8220ff to 04a32a7 Compare May 9, 2021 07:27
@ikesyo ikesyo force-pushed the becloseto-with-floatingpoint-protocol branch from 04a32a7 to 4e26051 Compare May 9, 2021 07:29
@ikesyo ikesyo marked this pull request as ready for review May 9, 2021 08:02
@ikesyo ikesyo merged commit 1c25df6 into master May 9, 2021
@ikesyo ikesyo deleted the becloseto-with-floatingpoint-protocol branch May 9, 2021 08:06
@ikesyo
Copy link
Member Author

ikesyo commented May 11, 2021

README's

Values given to the beCloseTo matcher must be coercable into a Double.

should be updated.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Float / Double matchers should use FloatingPoint protocol
2 participants