Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add beWithin matcher #886

Merged
merged 2 commits into from
May 11, 2021
Merged

Add beWithin matcher #886

merged 2 commits into from
May 11, 2021

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented May 10, 2021 •
edited
Loading

The original work is #837 by @sunshinejr 👏

This PR adds new matcher, beWithin, that checks if given comparable value is within given range. This is somewhat similar to be between from RSpec, but I've adapted that a bit to fit more with ranges.

@ikesyo ikesyo changed the title Add beWithin matcher Add beWithin matcher May 10, 2021
@ikesyo ikesyo force-pushed the feature/be_within branch from f1ee56f to 64616de Compare May 10, 2021 17:17
sunshinejr
sunshinejr approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@sunshinejr sunshinejr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for bringing it in!

@ikesyo ikesyo merged commit 96a3c42 into master May 11, 2021
@ikesyo ikesyo deleted the feature/be_within branch May 11, 2021 14:57
@ikesyo ikesyo mentioned this pull request May 11, 2021
Closed
@jessesquires jessesquires added this to the v10.0.0 milestone Apr 15, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sunshinejr sunshinejr sunshinejr approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v10.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ikesyo @sunshinejr @jessesquires