Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(next-international): added cookieName and headerName options #360

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

valentinpolitov
Copy link

@valentinpolitov valentinpolitov commented Feb 17, 2024

Added cookieName and headerName options to middleware config
closes #305

Copy link

vercel bot commented Feb 17, 2024

@valentinpolitov is attempting to deploy a commit to the Tom Labs Team on Vercel.

A member of the Team first needs to authorize it.

@QuiiBz
Copy link
Owner

QuiiBz commented Feb 17, 2024

Thanks for this PR! I'd like to include it in the V2, so we'll wait a bit before merging: #359

@ahmedelq
Copy link

Would love to use this. Any date for when V2 will be released?

@XtN
Copy link

XtN commented Jul 3, 2024

This option would be wonderful, but it should also include options for the cookie. Right now it's configured as SameSite=Strict which will result in ignoring the cookie on redirect. / -> will always go to locale from Accept-Language/or result of resolveLocaleFromRequest and not the preferred cookie value

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to change LOCALE_COOKIE constant
4 participants