Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: allow ignoring specific dependency and version for multiple-dependency-versions #84

Merged

Conversation

QuiiBz
Copy link
Owner

@QuiiBz QuiiBz commented Jul 30, 2024

Closes #83

This updates the --ignore-dependency / -ioption to allow passingdependency@version` arguments instead of only a dependency name.

@QuiiBz QuiiBz added the enhancement New feature or request label Jul 30, 2024
@bitttttten
Copy link

Thanks @QuiiBz ! 🫶

Although I am not sure I understand. Let's say we have React 17.0.1 and React 18.1.0, do we say "-i react@18.1.0" to allow 17.0.1 and 18.1.0? Did I understand the usage correctly?

@QuiiBz
Copy link
Owner Author

QuiiBz commented Aug 1, 2024

Good question, it's not "allowing" but rather "ignoring" a given version:

Let's say you have react@17 and react@18 installed in your monorepo, using -i react@17 will ignore this version so you won't have any error reported by Sherif.

If you have react@16, react@17, and react@18, using -i react@17 will still display an error because there is still react@16 and react@18 that have different versions (and aren't ignored).

@QuiiBz QuiiBz merged commit 4d0fee3 into main Aug 1, 2024
4 checks passed
@QuiiBz QuiiBz deleted the feat/multiple-dependency-versions-ignore-name-and-version branch August 1, 2024 15:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: explicitly allow multiple versions
2 participants