Improve mixin quality for Status Effect API #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OroArmor
added
bug
ix0rai
approved these changes
Sep 8, 2024
...ntity/status_effect/src/main/java/org/quiltmc/qsl/entity/effect/mixin/LivingEntityMixin.java
Outdated
Show resolved
Hide resolved
TheGlitch76
reviewed
Sep 20, 2024
...ntity/status_effect/src/main/java/org/quiltmc/qsl/entity/effect/mixin/LivingEntityMixin.java
Outdated
Show resolved
Hide resolved
TheGlitch76
approved these changes
Sep 20, 2024
…ity/effect/mixin/LivingEntityMixin.java Co-authored-by: ix0rai <ix0rai64@gmail.com>
OroArmor
force-pushed
the
remove-overwrites
branch
from
2574645 to
7bf32ef
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few crashes with this code. Should be fairly easy to backport to older versions if need be. I think some of the changes with
StatusEffect->Holder<StatusEffect>would need to be reverted.