Skip to content

fix(cloudflare): cache-control ignored by cf (#3679)" #5952

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Mar 5, 2024

This reverts commit 1995753.

Somehow, this causes cloudflare not to honor Cache-Control headers. The answers do not have the cache-hit header.

Fixes #5947

…ev#3679)"

This reverts commit 1995753.

Somehow, this causes the server to not send out correct Cache headers
Copy link

netlify bot commented Mar 5, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9235994

@wmertens wmertens enabled auto-merge (squash) March 5, 2024 14:00
@wmertens wmertens changed the title Revert "fix(cloudflare): wait to cache until response complete (#3679)" fix(cloudflare): cache-control ignored by cf (#3679)" Mar 5, 2024
@wmertens wmertens merged commit 6f2e515 into QwikDev:main Mar 5, 2024
@wmertens wmertens deleted the cf-fix branch March 5, 2024 14:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] The behaviour of the cache has changed 1.5.0 (cloudflare)
1 participant