Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SDTM #14

Merged
merged 1 commit into from
Nov 9, 2022
Merged

SDTM #14

merged 1 commit into from
Nov 9, 2022

Conversation

SHAESEN2
Copy link
Collaborator

@SHAESEN2 SHAESEN2 commented Nov 8, 2022

Copy link
Collaborator

@robertdevine robertdevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SHAESEN2.
@thomas-neitmann and @SHAESEN2 in projects with multiple data source repositories if commit history is to be captured from each source for purposes of provenance and traceability then best to provide prior to this merge. [In this case the Oct 5, 2016, commit history from the phuse-scripts repository for each sdtm data file would not be captured with the Pilot3 merge-commit. @SHAESEN2 's log message does capture the source url of the sdtm files which may be sufficient for purposes of Pilot3 studies. Pilot2 repository does not specify an sdtm source for data sets so the Pilot3 Team should decide how much scope to capture from the commit history in this case. Aside from that concern, we should be good to merge to main here. Thanks.]

@thomas-neitmann
Copy link

As there's literally no commit message on the original repo I think the best we can do is have the link to the source as part of the commit message.

@thomas-neitmann thomas-neitmann merged commit adba87e into main Nov 9, 2022
@robertdevine
Copy link
Collaborator

@thomas-neitmann For purpose of accuracy what is missed in the Pilot3 merge-commit is the timestamp record from the original sdtm commit event sourced from the phuse-scripts repository. Yes, sufficient for purposes of Pilot3 to proceed. Thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SDTM data from CDISC pilot repo
3 participants