Close #78 LOCF #87 adsl format discrepancy #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kaz462
commented
Mar 29, 2023
•
kaz462
commented
- remove the locf function workaround
- @DeclanHodges @SHAESEN2 I went ahead and resolved format discrepancy for adsl
added 2 commits
March 29, 2023 00:12
This was
linked to
issues
Mar 29, 2023
kaz462
requested review from
bms63,
DeclanHodges,
laxamanaj,
SHAESEN2 and
thomas-neitmann
laxamanaj
reviewed
Mar 30, 2023
| xportr_format(adsl_spec$var_spec %>% | ||
| mutate_at(c("format"), ~ replace_na(., "")), "ADSL") %>% | ||
| xportr_format(adsl_spec$var_spec %>% | ||
| mutate_at(c("format"), ~ replace_na(., "")), "ADSL") %>% |
There was a problem hiding this comment.
Thanks for updating this @kaz462 . I see that @DeclanHodges has other ADSL issues that he is working on in #88 and #94 .
@DeclanHodges , I'm going to go ahead and merge this branch to main which will update the adsl.R. Then you can get updated script from main before working on 88 and 94.
There was a problem hiding this comment.
Apologies I haven't had time to get around to reviewing this - thanks @kaz462 for updating this and @laxamanaj for reviewing!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.