Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Link libraries and the MSVC CRT statically #38

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NoahAndrews
Copy link
Member

This PR is blocked by changes needed from https://github.com/REVrobotics/CANBridge:

  • Even the static build of CANBridge is built using the /MD compiler option instead of /MT, so it still requires a compatible version of the Visual C++ Redistributable to be installed
    • After building CANBridge, you can see the compiler options used at build/tmp/compileCANBridgeWindowsx86-64ReleaseStaticLibraryCANBridgeCpp/options.txt
  • Once we prove the concept by using manually-extracted static WPILib artifacts from here and here, we should merge Update build system for Linux, macOS, overhaul GitHub Actions, remove serial driver CANBridge#37, as that already contains changes to upload all of the static libraries we'll need to future CANBridge releases.

@NoahAndrews NoahAndrews removed the request for review from LandryNorris December 31, 2024 00:16
@NoahAndrews NoahAndrews marked this pull request as draft December 31, 2024 00:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants