Merge pull request #18448 from nmeum/pr/stack-overflow-panic

core: Treat stack overflows as an unrecoverable error
RIOT-OS · Sep 21, 2022 · 6db9960 · 6db9960
2 parents 994ee9e + 8011665
commit 6db9960
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/core/lib/include/panic.h b/core/lib/include/panic.h
@@ -51,6 +51,7 @@ typedef enum {
     PANIC_DUMMY_HANDLER,        /**< unhandled interrupt */
 #endif
     PANIC_SSP,                  /**< stack smashing protector failure */
+    PANIC_STACK_OVERFLOW,       /**< stack overflow detected */
     PANIC_UNDEFINED
 } core_panic_t;
 

diff --git a/core/sched.c b/core/sched.c
@@ -30,6 +30,7 @@
 #include "log.h"
 #include "sched.h"
 #include "thread.h"
+#include "panic.h"
 
 #ifdef MODULE_MPU_STACK_GUARD
 #include "mpu.h"
@@ -130,9 +131,10 @@ static void _unschedule(thread_t *active_thread)
      */
     if (*((uintptr_t *)(uintptr_t)active_thread->stack_start) !=
         (uintptr_t)active_thread->stack_start) {
-        LOG_WARNING(
+        LOG_ERROR(
             "scheduler(): stack overflow detected, pid=%" PRIkernel_pid "\n",
             active_thread->pid);
+        core_panic(PANIC_STACK_OVERFLOW, "STACK OVERFLOW");
     }
 #endif
 #ifdef MODULE_SCHED_CB