drivers/periph_common/flashpage: fix silent error

This patch removes a test that silently hides failed writes to NULL. Instead, assert is used to ensure that the address is not NULL.
RIOT-OS · Jan 19, 2023 · bbe9103 · bbe9103
1 parent e248f95
commit bbe9103
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/drivers/periph_common/flashpage.c b/drivers/periph_common/flashpage.c
@@ -63,13 +63,12 @@ int flashpage_write_and_verify(unsigned page, const void *data)
 void flashpage_write_page(unsigned page, const void *data)
 {
     assert((unsigned) page < FLASHPAGE_NUMOF);
+    assert(data != NULL);
 
     flashpage_erase(page);
 
     /* write page */
-    if (data != NULL) {
-        flashpage_write(flashpage_addr(page), data, FLASHPAGE_SIZE);
-    }
+    flashpage_write(flashpage_addr(page), data, FLASHPAGE_SIZE);
 }
 #endif