Skip to content

Commit

Permalink
features.yaml: s/esp_eth/periph_eth/
Browse files Browse the repository at this point in the history
Use periph_eth instead of esp_eth for the Ethernet peripheral on ESP
MCUs for consistency
  • Loading branch information
maribu committed May 27, 2024
1 parent dd1e1d1 commit ded7217
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion boards/esp32-ethernet-kit-v1_0/Makefile.features
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ CPU_MODEL = esp32-wrover
include $(RIOTBOARD)/common/esp32/Makefile.features

# additional features provided by the board
FEATURES_PROVIDED += esp_eth
FEATURES_PROVIDED += periph_adc
FEATURES_PROVIDED += periph_eth
FEATURES_PROVIDED += periph_i2c
FEATURES_PROVIDED += periph_pwm

Expand Down
2 changes: 1 addition & 1 deletion boards/esp32-olimex-evb/Makefile.features
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ FEATURES_CONFLICT += periph_sdmmc:periph_spi
FEATURES_CONFLICT_MSG += "SD/MMC and SPI cannot be used at the same time on this board."

# unique features of the board
FEATURES_PROVIDED += esp_eth # Ethernet MAC (EMAC)
FEATURES_PROVIDED += periph_can # CAN peripheral interface
FEATURES_PROVIDED += periph_eth # Ethernet MAC (EMAC)

FEATURES_PROVIDED += arduino_pins
2 changes: 1 addition & 1 deletion cpu/esp32/Makefile.dep
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ ifneq (,$(filter esp_ble,$(USEMODULE)))
endif

ifneq (,$(filter esp_eth,$(USEMODULE)))
FEATURES_REQUIRED += esp_eth
FEATURES_REQUIRED += periph_eth
USEMODULE += esp_idf_eth
USEMODULE += esp_idf_event
USEMODULE += esp_idf_gpio
Expand Down
4 changes: 0 additions & 4 deletions features.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,6 @@ groups:
- title: ESP Specific Features
help: These features are only available on (some) ESP MCUs.
features:
- name: esp_eth
help: >
An ESP Ethernet peripherals is available.
(FIXME: `periph_eth` instead.)
- name: esp_jtag
help: The MCU supports JTAG for programming and debugging. Enable this
feature to expose the interface at the cost of having fewer pins as
Expand Down

0 comments on commit ded7217

Please # to comment.