Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

gnrc_sixlowpan_frag: encapsulate msg_send_to_self() #11063

Merged
merged 1 commit into from
Mar 26, 2019
Merged

gnrc_sixlowpan_frag: encapsulate msg_send_to_self() #11063

merged 1 commit into from
Mar 26, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Feb 25, 2019 •
edited
Loading

Contribution description

This makes it easier to access this functionality for test cases e.g. from the main thread.

Testing procedure

gnrc_networking with fragmented packets (e.g. ping6 -s 120 <link-layer address>) should still work. Neither code nor RAM size should change.

Issues/PRs references

None but required for minimal fragment forwarding tests:

Route to 6Lo minimal fragment forwarding

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 25, 2019
@miri64 miri64 added this to the Release 2019.04 milestone Feb 25, 2019
@miri64 miri64 force-pushed the gnrc_sixlowpan_frag/enh/msg-send-to-6lo branch from e287ea7 to 15a1dfa Compare February 25, 2019 16:16
@miri64 miri64 mentioned this pull request Feb 26, 2019
Merged
@PeterKietzmann
Copy link
Member

I can confirm that ping6 -s 1200 <link local addy> still works between two samr21-xpro nodes and tests/gnrc_sixlowpan_frag succeeds. I'm not really involved in the 6LoWPAN restructuring so I can't tell if the change is needed / reasonable.

@PeterKietzmann PeterKietzmann added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label Feb 27, 2019
@miri64
gnrc_sixlowpan_frag: encapsulate msg_send_to_self()
931b179 
This makes it easier to access this functionality for test cases e.g.
from the `main` thread.
@miri64 miri64 force-pushed the gnrc_sixlowpan_frag/enh/msg-send-to-6lo branch from 15a1dfa to 931b179 Compare March 8, 2019 18:33
@miri64
Copy link
Member Author

miri64 commented Mar 8, 2019

Rebased to current master to resolve conflict caused by merging #11135.

@PeterKietzmann PeterKietzmann added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 26, 2019
PeterKietzmann
PeterKietzmann approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@PeterKietzmann PeterKietzmann merged commit f6efecc into RIOT-OS:master Mar 26, 2019
@miri64
Copy link
Member Author

miri64 commented Mar 26, 2019

Thank you for reviewing :-)

@miri64 miri64 deleted the gnrc_sixlowpan_frag/enh/msg-send-to-6lo branch March 26, 2019 20:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.04
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @PeterKietzmann