gnrc_sixlowpan: clean-up configuration and expose via config group #11415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: enhancement
|
thanks for tackling this! Murdock complains because of undocumented defines |
miri64
force-pushed
the
gnrc_sixlowpan/enh/expose-config
branch
from
c3a004e to
9192287
Compare
|
Piggy-backed documentation on those two functions, Murdock and Travis were complaining about. |
|
Got permission to squash offline |
miri64
force-pushed
the
gnrc_sixlowpan/enh/expose-config
branch
from
413e59b to
6610ac9
Compare
|
Fixed Murdock complained |
Both values are not standardized so there is no sense keeping these values not configurable
This adds documentation for the following undocumented functions: - rbuf_rm() - rbuf_entry_empty()
miri64
force-pushed
the
gnrc_sixlowpan/enh/expose-config
branch
from
39a0637 to
43dedfc
Compare
|
And squashed again. |
|
Thanks for the review! |
This was referenced Apr 18, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Bringing GNRC's 6LoWPAN module towards #10566 (also I need the last part for my current experiments ;-)). This PR
net/gnrc/sixlowpan/nd/border_router.hheader, since the only define in it is nowhere used,net/gnrc/sixlowpan*tonet/gnrc/sixlowpan/config.h, andRBUF_SIZEandRBUF_TIMEOUTfor compile time configuration via the new macrosGNRC_SIXLOWPAN_FRAG_RBUF_SIZEandGNRC_SIXLOWPAN_FRAG_RBUF_TIMEOUT_MSrespectively.Testing procedure
Read and compile (the latter should still work, I don't know about the first ;-)).
Issues/PRs references
Addresses #10566