stm32l1/vendor: update vendor files to v2.3.0 #11489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjmolinas
added
Area: cpu
aabadie
added
the
CI: ready for build
fjmolinas
force-pushed
the
pr-update_stm32l1-cmsis
branch
from
cb179dc to
c43091b
Compare
|
@aabadie split in two commits following your offline comments! |
|
I ran Here is the gdb output: |
|
I get the following failing tests which I think are all to be expected. Doesn't have the driver so expected to fail Needs sudo: Needs SD-Card: Timeouts Early: Also fails in master:
This is fixed if removing #8518 changes or adding more NOP... (I don't trust removing it though without more arguments). The tests/applications work fine if node is connected and disconnected after flashing.... weird.. The ones you mention is passing for me, what are your toolchains? mine are: |
|
@aabadie replicating with different toolchain I get your described behavior. But If I remove optimization the problem is fixed too, so there is clearly an optimization problem that depends on gcc version, in #8518 it indicated that some optimization was going on an causing the fault, although the fact that |
fjmolinas
force-pushed
the
pr-update_stm32l1-cmsis
branch
from
c43091b to
1d54621
Compare
fjmolinas
removed
the
CI: ready for build
|
The issues should be fixed with #11830. |
fjmolinas
added
the
State: waiting for other PR
fjmolinas
force-pushed
the
pr-update_stm32l1-cmsis
branch
2 times, most recently
from
3804f69 to
c92af33
Compare
- remove old header files - fix new DMA header file macro definitions - remove old cpu type groups (STM32L1XX_MD, STM32L1XX_MDP, STM32L1XX_HD, STM32L1XX_XL)
fjmolinas
force-pushed
the
pr-update_stm32l1-cmsis
branch
from
c92af33 to
e4a49f0
Compare
|
rebased |
fjmolinas
added
CI: ready for build
|
I launched the tests again, building in docker: |
|
This tests fails because of a timeout, when timeout=12s: I'll open a separate PR for this. I think this is OK with the test results. |
aabadie
approved these changes
Aug 5, 2019
There was a problem hiding this comment.
I confirm the test results reported by @fjmolinas. Let's merge this.
ACK
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR updates stm32l1xx CMSIS header files to v2.3.0.
The following changes here made to the original Header files:
system_stm32l1xx.hhttps://github.com/modm-io/cmsis-header-stm32/blob/b319e58b1442a77e79812d8bf9063b7221ba4f64/stm32l1xx/Include/stm32l151xca.h#L77
Testing procedure
Run all tests for nucleo-l152re or other stm32l1 based boards.
python dist/tools/compile_and_test_for_board/compile_and_test_for_board.py --jobs 0 . nucleo-l152reIssues/PRs references
Depends on
#11830.