Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

sys/sock/util: allow overriding of SOCK_*_MAXLEN #11558

Merged
merged 1 commit into from
May 21, 2019
Merged

sys/sock/util: allow overriding of SOCK_*_MAXLEN #11558

merged 1 commit into from
May 21, 2019

Conversation

kaspar030
Copy link
Contributor

Contribution description

sock_util has some hard-coded defines for maximum url lengths.
This PR allows overriding them.

This came up with quite long SUIT update URLs here.

Testing procedure

Let CI do its magic.

Issues/PRs references

@kaspar030 kaspar030 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 21, 2019
@kaspar030 kaspar030 requested a review from fjmolinas May 21, 2019 10:10
@kaspar030 kaspar030 mentioned this pull request May 21, 2019
Closed
fjmolinas
fjmolinas approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ACK

@fjmolinas fjmolinas merged commit 96d9400 into RIOT-OS:master May 21, 2019
@fjmolinas fjmolinas mentioned this pull request May 21, 2019
Merged
@miri64
Copy link
Member

miri64 commented May 21, 2019

Can you please adapt this in accordance to #10566?

@fjmolinas fjmolinas mentioned this pull request May 21, 2019
Merged
@fjmolinas
Copy link
Contributor

@miri64 Sorry I wasn't fully conscious about #10566, fixed with #11561.

@kaspar030 kaspar030 deleted the pr/sock_util/make_maxlengths_configurable branch May 22, 2019 07:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaspar030 @miri64 @fjmolinas