driver/tmp00x: make tmp006 more generic #12022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterKietzmann
added
Area: drivers
MrKevinWeiss
requested changes
Aug 19, 2019
JannesVolkens
force-pushed
the
tmp00x
branch
2 times, most recently
from
160d64e to
39bcdae
Compare
MrKevinWeiss
added
the
CI: ready for build
drivers/include/tmp00x.h
Outdated
| @@ -88,30 +89,67 @@ extern "C" | |||
| { | |||
| #endif | |||
|
|
|||
| #define TMP00X_CONFIG_RST (1 << 15) /**< Reset register */ | |||
There was a problem hiding this comment.
Actually, a lot of this should be in the tmp00x_regs.h not here. This is only to be exposed to the user of the driver. They probably shouldn't have to care about the shift register and masks.
Rename TMP006 to TMP00x Add TMP007 sensor support to TMP00X Change uint8_t reg to uint16_t Add to doxygen documentation group Expose compile time configurations Move defines from .c to .h Change double to float, because double is not needed Add TMP007 register information
MrKevinWeiss
approved these changes
Aug 23, 2019
|
Congrats on your first PR! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The driver for the TMP006 Infrared Thermopile Sensor has been modified to work for the TMP006 and TMP007. The driver was tested with the CC2650-launchpad
Testing procedure
The test under tests/driver_tmp00x can be performed normally for the TMP006 sensor. The following parameter must be set for the TMP007 sensor: DRIVER=tmp007