-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
gnrc_sixlowpan_frag: factor-out and rename fragmentation buffer #12559
Merged
miri64
merged 2 commits into
RIOT-OS:master
from
miri64:gnrc_sixlowpan_frag/enh/factor-out-frag-buf
Nov 7, 2019
Merged
gnrc_sixlowpan_frag: factor-out and rename fragmentation buffer #12559
miri64
merged 2 commits into
RIOT-OS:master
from
miri64:gnrc_sixlowpan_frag/enh/factor-out-frag-buf
Nov 7, 2019
+273
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54e2715
to
87f7769
Compare
Rebased to current master. |
7ede405
to
ddf9354
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Oct 31, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 1, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 1, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 1, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 1, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 4, 2019
The name `fragment_msg` or `frag_msg`/`msg_frag` always to me was a bit misplaced, as it basically implements an asynchronous fragmentation buffer and doesn't necessarily have anything to do with messages. This change 1. changes the name to `fb` (for fragmentation buffer) 2. factors its code out to its own sub-module so it can be re-used by other 6LoWPAN fragmentation schemes like [Selective Fragment Recovery] [Selective Fragment Recovery]: https://tools.ietf.org/html/draft-ietf-6lo-fragment-recovery-05
d270331
to
ca37cde
Compare
Rebased to current master |
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 5, 2019
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Nov 6, 2019
benpicco
approved these changes
Nov 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really just renames and moves code around.
No functional changes expected.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Area: network
Area: Networking
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The name
fragment_msg
orfrag_msg
/msg_frag
always to me was a bit misplaced, as it basically implements an asynchronous fragmentation buffer and doesn't necessarily have anything to do with messages. This changefb
(for fragmentation buffer)Testing procedure
still works (I tested on
native
andsamr21-xpro
) and pinging large (>100 bytes) packets between two nodes using 6LoWPAN (e.g.iotlab-m3
) withexamples/gnrc_networking
still works and shows comparable performance to master (tested in the IoT-LAB in my case).In this PR:
On master:
Issues/PRs references
None