drivers/nrf24l01p: fix potentially undefined return value #12587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Type: cleanup
aabadie
force-pushed
the
pr/drivers/nrf24l01p_scan_build
branch
from
9869557 to
283a906
Compare
benpicco
reviewed
Oct 27, 2019
drivers/nrf24l01p/nrf24l01p.c
Outdated
| @@ -618,30 +618,13 @@ int nrf24l01p_set_power(const nrf24l01p_t *dev, int pwr) | |||
| return nrf24l01p_write_reg(dev, REG_RF_SETUP, rf_setup); | |||
| } | |||
|
|
|||
| static const int _nrf24l01p_power_map[4] = { -18, -12, -6, 0 }; | |||
There was a problem hiding this comment.
You can save a few bytes and use int8_t[] here.
There was a problem hiding this comment.
I tested and this makes no difference in code size. Anyway I think it's better to be explicit and use int8_t instead of int.
I pushed the change, directly squashed.
aabadie
force-pushed
the
pr/drivers/nrf24l01p_scan_build
branch
from
283a906 to
808e442
Compare
benpicco
approved these changes
Oct 28, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes a potentially uninitialized returned value in the nrf24l01p driver.
The problem is raised when running scan-build with the LLVM toolchain.
After checking the datasheet, it seems that the returned value is quite deterministic (4 possible values, coded on 2 bits). So using using a map containing the expected power values should work.
Testing procedure
Issues/PRs references
Tick one item in #11852