sys/net/uhcp: remove unused returned value in uhcp_client #12588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Area: network
|
Better just return immediately if Also line 47 should be |
kaspar030
reviewed
Oct 28, 2019
| @@ -37,7 +37,7 @@ void uhcp_client(uhcp_iface_t iface) | |||
| req.prefix_len = 64; | |||
|
|
|||
| /* create listening socket */ | |||
| int res = sock_udp_create(&sock, &local, NULL, 0); | |||
| sock_udp_create(&sock, &local, NULL, 0); | |||
There was a problem hiding this comment.
This should be handled...
aabadie
force-pushed
the
pr/net/uhcp_scan_build
branch
from
4e8895f to
a939981
Compare
|
Ok, I changed this PR to take into account the return code and return immediately with an error message. |
benpicco
approved these changes
Oct 28, 2019
kaspar030
requested changes
Oct 28, 2019
kaspar030
approved these changes
Oct 28, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is an obvious fix removing a return value set in a variable that is never used afterward.
The ideal fix would be to take into account the return code in case of an error but that would need an API change in uhcp.
Testing procedure
Run
TOOLCHAIN=llvm make -C examples/gnrc_border_router/ scan-buildWith this PR the warning related to uhcp is gone.
Issues/PRs references
Tick another item in #11852