Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

drivers/include/ds1307.h : Compile Configs #13775

Merged
merged 1 commit into from
Apr 1, 2020
Merged

drivers/include/ds1307.h : Compile Configs #13775

merged 1 commit into from
Apr 1, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Apr 1, 2020

Contribution description

Identify Compile Time Parameters in drivers/include/ds1307.h header and expose it.

Note : Skipped the following since its not configurable. Device's address on I2C bus is hard coded as it does not have address pins.

#define DS1307_I2C_ADDRESS (0x68)

Testing procedure

Doxygen build works fine.

Issues/PRs references

#10566

@akshaim
Copy link
Member Author

akshaim commented Apr 1, 2020

@leandrolanzieri Kindly review

@MrKevinWeiss MrKevinWeiss added Area: drivers Area: Device drivers Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Apr 1, 2020
MrKevinWeiss
MrKevinWeiss approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, it shows up in the DS1307 compile time config. ACK.

@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Apr 1, 2020
@leandrolanzieri leandrolanzieri merged commit 6f30086 into RIOT-OS:master Apr 1, 2020
@akshaim akshaim deleted the ds1307_CT_Config branch April 21, 2020 08:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaim @MrKevinWeiss @leandrolanzieri