Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

riotctrl_shell.netif: fix for multiple interfaces with netstats [backport 2020.07] #14522

Merged
merged 2 commits into from
Jul 15, 2020
Merged

riotctrl_shell.netif: fix for multiple interfaces with netstats [backport 2020.07] #14522

merged 2 commits into from
Jul 15, 2020

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 15, 2020

Backport of #14510

Contribution description

This provides a fix to riotctrl_shell.netif for when there is more than one interface and network statistics are provided. I also added a regression test for that.

Testing procedure

cd dist/pythontools/riotctrl_shell; tox, or just let tools-test do its thing :-)

Issues/PRs references

Required for the test integration of release spec 10-icmpv6-error (see RIOT-OS/Release-Specs#167).

@miri64 miri64 added Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jul 15, 2020
@miri64 miri64 requested a review from jia200x July 15, 2020 13:25
@miri64 miri64 mentioned this pull request Jul 15, 2020
Merged
jia200x
jia200x approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64
Copy link
Member Author

miri64 commented Jul 15, 2020

We did not activate the workflows for the release branches.. I deactivate the branch protection regarding them for now.

@miri64 miri64 merged commit d4531f7 into RIOT-OS:2020.07-branch Jul 15, 2020
@miri64 miri64 deleted the backport/2020.07/riotctrl.netif/bug/multi-iface-w-stats branch July 15, 2020 15:42
This was referenced Jul 15, 2020
Merged
Merged
@miri64 miri64 added this to the Release 2020.07 milestone Jul 23, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jia200x jia200x jia200x approved these changes

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @jia200x