Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

make: only build MacOS-specific tool on MacOS #14644

Merged
merged 1 commit into from
Jul 30, 2020
Merged

make: only build MacOS-specific tool on MacOS #14644

merged 1 commit into from
Jul 30, 2020

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 28, 2020

Contribution description

The comment says as much, the tool in question even has macosx in its name [1], and it does not build for other non-Linux-POSIX systems such as FreeBSD.

Testing procedure

make debug should work on Mac OSX and FreeBSD (see #14458)

Issues/PRs references

Discovered in #14631 (comment)

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system Area: tools Area: Supplementary tools labels Jul 28, 2020
@miri64 miri64 added this to the Release 2020.10 milestone Jul 28, 2020
@miri64 miri64 requested review from aabadie and fjmolinas July 28, 2020 16:39
fjmolinas
fjmolinas reviewed Jul 29, 2020
View reviewed changes
@fjmolinas
Copy link
Contributor

@miri64 is setsid not available under any form under FreeBSD?

@miri64
Copy link
Member Author

miri64 commented Jul 29, 2020 •
edited
Loading

@miri64 is setsid not available under any form under FreeBSD?

Not sure, but it is not needed to execute make debug / gdb as far as I can tell.

@miri64
Copy link
Member Author

miri64 commented Jul 29, 2020

Just installing gdb

sudo pkg install gdb

is enough

@fjmolinas
Copy link
Contributor

@miri64 can you see if #8424 (comment) applies?

@miri64
Copy link
Member Author

miri64 commented Jul 29, 2020 •
edited
Loading

@miri64 can you see if #8424 (comment) applies?

I currently only try to get native to run in FreeBSD, so no I can't see it ;-).

fjmolinas
fjmolinas approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best fix would be be to use https://github.com/jerrykuch/ersatz-setsid as the compiled lib. But this PR is not wrong since the current pkg is OSX specific.

@fjmolinas
Copy link
Contributor

@miri64 please squash.

fjmolinas
fjmolinas requested changes Jul 29, 2020
View reviewed changes
@miri64
make: only build MacOS-specific tool on MacOS
44cf4a9 
The comment says as much, the tool in question even has `macosx` in its
name [1], and it does not build for other non-Linux-POSIX systems such
as FreeBSD.

[1]: https://github.com/tzvetkoff/setsid-macosx
@miri64 miri64 force-pushed the make/fix/macosx-debug branch from 7cef297 to 44cf4a9 Compare July 29, 2020 11:58
@miri64
Copy link
Member Author

miri64 commented Jul 29, 2020

Squashed

fjmolinas
fjmolinas approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ACK

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 29, 2020
@miri64
Copy link
Member Author

miri64 commented Jul 29, 2020

Not skipping compile-tests in case something went wrong since this is pretty central in the build system files ;-).

@fjmolinas fjmolinas merged commit 1aa8fb1 into RIOT-OS:master Jul 30, 2020
@miri64 miri64 deleted the make/fix/macosx-debug branch July 30, 2020 14:44
@miri64
Copy link
Member Author

miri64 commented Jul 30, 2020

Thanks for the review!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@aabadie aabadie Awaiting requested review from aabadie

Assignees
No one assigned
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2020.10
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @fjmolinas