Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

pkg/arduino_adafruit_sensor: add Adafruit Unified Sensor Driver as package #17460

Merged
merged 2 commits into from
Jan 15, 2023
Merged

pkg/arduino_adafruit_sensor: add Adafruit Unified Sensor Driver as package #17460

merged 2 commits into from
Jan 15, 2023

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Jan 2, 2022 •
edited
Loading

Contribution description

This PR provides the Adafruit Unified Sensor Driver as package.

There are a number of Adafruit sensor drivers which all use a common base class Adafruit_Sensor from the Adafruit Unified Sensor Driver. To support such drivers, the Adafruit Unified Sensor Driver is provided as package.

Adafruit sensor driver for ST LSM9DS0 will be provided as separat PR as package for demonstration and testing.

PR #12518 will be rebased for testing to have an Adafruit sensor driver for a sensor for which there is a native driver in RIOT.

Testing procedure

Use a board that provides the arduino feature and flash

BOARD=... make -C tests/pkg_arduino_adafruit_sensor flash test

PR #12518 can be used as a more complex test for using the package.

Issues/PRs references

Prerequisite for PR #12518

@github-actions github-actions bot added Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Area: tests Area: tests and testing framework labels Jan 2, 2022
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Jan 2, 2022
@gschorcht gschorcht mentioned this pull request Jan 2, 2022
Open
@gschorcht gschorcht force-pushed the pkg/arduino_adafruit_sensor branch 2 times, most recently from e0433d3 to 8d32d6d Compare January 3, 2022 05:08
@gschorcht gschorcht mentioned this pull request Jan 3, 2022
Merged
@gschorcht gschorcht removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 3, 2022
@gschorcht gschorcht force-pushed the pkg/arduino_adafruit_sensor branch from 8d32d6d to e577981 Compare January 3, 2022 17:00
@gschorcht gschorcht mentioned this pull request Jan 3, 2022
Open
@gschorcht gschorcht force-pushed the pkg/arduino_adafruit_sensor branch from e577981 to fa7d4d9 Compare January 5, 2022 05:19
fjmolinas
fjmolinas reviewed Jan 17, 2022
View reviewed changes
pkg/arduino_adafruit_sensor/Makefile.include
@@ -0,0 +1,2 @@
CFLAGS += "-DARDUINO = 100"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor Author

@gschorcht gschorcht Jan 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just says the source code of the package that we have an Arduino version >= 1.0. This is usually set by the Arduino IDE.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a comment? Squashing out that f and triggering ci?

fjmolinas
fjmolinas reviewed Jan 17, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one tiny questio above, also I see a trailing f in the commit message of fa7d4d9 that bothers my TOC

@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 13, 2022
@gschorcht gschorcht removed the State: stale State: The issue / PR has no activity for >185 days label Aug 13, 2022
@gschorcht
pkg/arduino_adafruit_sensor: add Adafruit Unified Sensor Driver
7aab412 
A number of Adafruit sensor drivers use the class Adafruit_Sensor from the Adafruit Unified Sensor Driver. To support such drivers, the Adafruit Unified Sensor Driver is imported as package.
@gschorcht
tests/pkg_arduino_adafruit_sensor: add test app
6b9690c
@gschorcht
Copy link
Contributor Author

Looks good, one tiny questio above, also I see a trailing f in the commit message of fa7d4d9 that bothers my TOC

Ok, after almost a year I rebased the PR onto the latest master and fixed the comment in the commit messages. The only change is that I upgraded the package to the latest version of the package.

@gschorcht gschorcht force-pushed the pkg/arduino_adafruit_sensor branch from fa7d4d9 to 6b9690c Compare December 15, 2022 20:07
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 14, 2023
@riot-ci
Copy link

riot-ci commented Jan 15, 2023

Murdock results

✔️ PASSED

6b9690c tests/pkg_arduino_adafruit_sensor: add test app

Success Failures Total Runtime
6771 0 6772 14m:25s

Artifacts

@benpicco
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 15, 2023

Build succeeded:

@bors bors bot merged commit b8b1a60 into RIOT-OS:master Jan 15, 2023
@gschorcht
Copy link
Contributor Author

Thanks for reviewing and merging.

@jia200x jia200x added this to the Release 2023.04 milestone Apr 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fjmolinas fjmolinas fjmolinas left review comments

@benpicco benpicco benpicco approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@smlng smlng Awaiting requested review from smlng

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

Assignees
No one assigned
Labels
Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
5 participants
@gschorcht @riot-ci @benpicco @fjmolinas @jia200x