pkg/esp32_sdk: additional patches required for ESP32-C3 #18339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
added
Type: new feature
benpicco
reviewed
Jul 20, 2022
| From a32436c8bc11a0b956d95fbdd535e83e004347d5 Mon Sep 17 00:00:00 2001 | ||
| From: Gunar Schorcht <gunar@schorcht.net> | ||
| Date: Thu, 10 Mar 2022 13:10:23 +0100 | ||
| Subject: [PATCH 20/20] freertos/portasm: changes for RIOT for riscv32 |
There was a problem hiding this comment.
What are those changes / why are they needed?
Would be valuable information when updating the SDK in the future
There was a problem hiding this comment.
I suppose you mean comments in the commits as I provided in the fix.
| From ca93a21d6e2bc58d1d32da594351bb03f94343a0 Mon Sep 17 00:00:00 2001 | ||
| From: Gunar Schorcht <gunar@schorcht.net> | ||
| Date: Thu, 10 Mar 2022 12:38:51 +0100 | ||
| Subject: [PATCH 18/20] bootloader: changes for esp32c3 |
There was a problem hiding this comment.
What are those changes / why are they needed?
Future readers will need this information.
github-actions
bot
removed
the
Platform: ESP
fixup! pkg/esp32_sdk: additional patches required for ESP32-C3
gschorcht
force-pushed
the
pkg/esp32/patches_for_esp32c3
branch
from
e74e2be to
001ddc6
Compare
|
@benpicco Were your concerns sufficiently addressed? |
benpicco
approved these changes
Jul 21, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a split-off from PR #17844, which provides additional patches of
pkg/esp32_sdkrequired for ESP32-C3.Testing procedure
It is not yet possible to cover this PR when compiling in CI without having ESP32-C3 support and a board definition with an ESP32-C3. Vice versa, the ESP32-C3 port that needs this PR cannot be compiled in CI without it.
Therefore a green CI with the label
CI: skip compile testmust be sufficient for the moment. If it doesn't work, the problem will pop up as soon as ESP32-C3 support is provided. And of course, I have tested it together with the ESP32-C3 support in PR #17844.Issues/PRs references
Split-off from PR #17844