net/gnrc_netif: add support for priority queues #18496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jia200x
requested review from
miri64,
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
jia200x
force-pushed
the
pr/gnrc_netif_multi_queue
branch
from
3166c98 to
e2efc90
Compare
|
amended and squashed directly |
benpicco
added
the
CI: ready for build
jia200x
force-pushed
the
pr/gnrc_netif_multi_queue
branch
from
e2efc90 to
c99bb72
Compare
|
I already tested this one with #18472 and it definitely helps the SubMAC or any MAC layer in the middle |
|
CI is unhappy |
jia200x
force-pushed
the
pr/gnrc_netif_multi_queue
branch
from
c99bb72 to
5fd601a
Compare
|
I forgot GNRC LoRaWAN and the other MACs use |
|
Thanks for the review! |
maribu
added a commit
to maribu/RIOT
that referenced
this pull request
Apr 30, 2024
This fixes a regression introduced in RIOT-OS#18496
maribu
added a commit
to maribu/RIOT
that referenced
this pull request
May 8, 2024
This fixes a regression introduced in RIOT-OS#18496
ant9000
pushed a commit
to ant9000/RIOT
that referenced
this pull request
Aug 23, 2024
This fixes a regression introduced in RIOT-OS#18496
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds support for
gnrc_netifpriority queues.Since some drivers run a Bottom Half Processor in the same
gnrc_netifthread, events from MAC layers (e.g submac) can delay IRQ offloading. To avoid that, a second event queue with high priority is introduced ifMODULE_BHP_EVENTis present.I also use this queue for the event based Bottom Half Processor of
kw2xrfradios.Testing procedure
Make sure all unittests pass. Also,
kw2xrfshould still work in GNRC.Since I'm currently on the train I couldn't test it on real hardware. I will post tests results asap.
Issues/PRs references
This should make MAC layers such as the SubMAC or openDSME more robust.