Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

cpu/mips: Remove all mips #18562

Merged
merged 2 commits into from
Sep 30, 2022
Merged

cpu/mips: Remove all mips #18562

merged 2 commits into from
Sep 30, 2022

Conversation

MrKevinWeiss
Copy link
Contributor

Contribution description

Starting the remove mips CPU that was originally done by @jcarrano

Testing procedure

Green CI and read it.

Issues/PRs references

@github-actions github-actions bot added Area: boards Area: Board ports Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: CoAP Area: Constrained Application Protocol implementations Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools Platform: MIPS Platform: This PR/issue effects MIPS-based platforms labels Sep 6, 2022
maribu
maribu reviewed Sep 9, 2022
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for tackling this. It really is impressive to see what level of effort the MIPS toolchain caused and how little it is used

@maribu maribu mentioned this pull request Sep 12, 2022
Merged
maribu
maribu approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. This needs a rebase now (and adaption of the changes to the flashing doc), other than that it should be good to go

@MrKevinWeiss MrKevinWeiss force-pushed the pr/removemips branch 2 times, most recently from 3391e6b to 47b2bb5 Compare September 27, 2022 09:58
@maribu
Copy link
Member

maribu commented Sep 27, 2022

There seems to still be some files left. The CI is listing cpu/mips32r2_common/include/cpu.h below "Unchanged files with check annotations"

@MrKevinWeiss
Copy link
Contributor Author

Rebased and updated lost and found!

@MrKevinWeiss MrKevinWeiss added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 27, 2022
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 27, 2022
@chrysn chrysn added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 27, 2022
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 27, 2022
@chrysn chrysn added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 27, 2022
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 27, 2022
@kaspar030 kaspar030 merged commit 3ee3d1b into RIOT-OS:master Sep 30, 2022
@MrKevinWeiss MrKevinWeiss deleted the pr/removemips branch October 4, 2022 09:04
@MrKevinWeiss
Copy link
Contributor Author

Thanks, the codebase is getting cleaner and cleaner!

@kaspar030 kaspar030 mentioned this pull request Oct 12, 2022
Merged
bors bot added a commit to RIOT-OS/riotdocker that referenced this pull request Oct 12, 2022
@bors @kaspar030
Merge #212
7bb4d7f 
212: remove pic32-wifire from BOARDS r=chrysn a=kaspar030

MIPS support was removed: RIOT-OS/RIOT#18562

Co-authored-by: Kaspar Schleiser <kaspar@schleiser.de>
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
@crasbe crasbe mentioned this pull request Jan 21, 2025
Merged
@MrKevinWeiss MrKevinWeiss mentioned this pull request Jan 27, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@maribu maribu maribu approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@smlng smlng Awaiting requested review from smlng

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: CoAP Area: Constrained Application Protocol implementations Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MIPS Platform: This PR/issue effects MIPS-based platforms
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
5 participants
@MrKevinWeiss @maribu @chrysn @benpicco @kaspar030