-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
pkg/cryptoauthlib: Pass ATCA_NO_HEAP Flag to library #18705
Conversation
Murdock results✔️ PASSED 2be8b22 pkg/cryptoauthlib: Pass ATCA_NO_HEAP Flag to library
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Running:
BOARD=acd52832 TEST_KCONFIG=1 make -C tests/pkg_cryptoauthlib_compare_sha256/
now passes, but fails in master. Also it makes sense, the only thing I didn't understand is why it works with regular make. Oh well...
I took a look at it and what I've found is, that cmake (which is being used to build the cryptoauthlib), generates an If we don't pass it and build with I don't know why that is, but since we don't want to use malloc and free, I think this is the best fix, because it actually leads to the correct library configuration. |
Contribution description
ATCA_NO_HEAP must be passed to cryptoauthlib build system in order to not use dynamic memory allocation.
Build fails when using KCONFIG for dependency resolution, because ATCA_NO_HEAP is not defined.
This fixes the problem.
Testing procedure
Build
tests/pkg_cryptoauthlib_compare_sha256/
using KCONFIG dependency resolution.