Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

drivers/atwinc15x0: don't disable interrupts #18800

Merged
merged 1 commit into from
Oct 26, 2022
Merged

drivers/atwinc15x0: don't disable interrupts #18800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions drivers/atwinc15x0/atwinc15x0_netdev.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
#include "driver/include/m2m_wifi.h"

#include "assert.h"
#include "irq.h"
#include "log.h"
#include "net/netdev/eth.h"
#include "od.h"
Expand Down Expand Up @@ -123,13 +122,9 @@ static void _atwinc15x0_eth_cb(uint8_t type, void *msg, void *ctrl_buf)
/* the buffer shouldn't be used here */
assert(atwinc15x0->rx_buf == NULL);

uint32_t state = irq_disable();

atwinc15x0->rx_buf = msg;
atwinc15x0->rx_len = ctrl->u16DataSize;

irq_restore(state);

/**
* This function is executed in the thread context. Therefore
* netdev.event_callback can be called directly, which avoids an
Expand Down Expand Up @@ -270,13 +265,11 @@ static int _atwinc15x0_send(netdev_t *netdev, const iolist_t *iolist)
/* atwinc15x0_eth_buf should not be used for incoming packets here */
assert(dev->rx_buf == NULL);

uint32_t state = irq_disable();
uint16_t tx_len = 0;

/* load packet data into the buffer */
for (const iolist_t *iol = iolist; iol; iol = iol->iol_next) {
if (tx_len + iol->iol_len > ETHERNET_MAX_LEN) {
irq_restore(state);
return -EOVERFLOW;
}
if (iol->iol_len) {
Expand All @@ -292,8 +285,6 @@ static int _atwinc15x0_send(netdev_t *netdev, const iolist_t *iolist)
}
}

irq_restore(state);

/* send the the packet */
if (m2m_wifi_send_ethernet_pkt(atwinc15x0_eth_buf, tx_len) == M2M_SUCCESS) {
netdev->event_callback(netdev, NETDEV_EVENT_TX_COMPLETE);
Expand All @@ -313,12 +304,10 @@ static int _atwinc15x0_recv(netdev_t *netdev, void *buf, size_t len, void *info)
assert(dev);
assert(dev == atwinc15x0);

uint32_t state = irq_disable();
uint16_t rx_size = dev->rx_len;

if (!rx_size) {
/* there is nothing in receive buffer */
irq_restore(state);
return 0;
}

Expand All @@ -329,7 +318,6 @@ static int _atwinc15x0_recv(netdev_t *netdev, void *buf, size_t len, void *info)
dev->rx_len = 0;
dev->rx_buf = NULL;
}
irq_restore(state);
return rx_size;
}

Expand All @@ -339,7 +327,6 @@ static int _atwinc15x0_recv(netdev_t *netdev, void *buf, size_t len, void *info)
/* newest API requires to drop the frame in that case */
dev->rx_len = 0;
dev->rx_buf = NULL;
irq_restore(state);
return -ENOBUFS;
}

Expand All @@ -358,8 +345,6 @@ static int _atwinc15x0_recv(netdev_t *netdev, void *buf, size_t len, void *info)
}
}

irq_restore(state);

return rx_size;
}

Expand Down