makefiles/gnu.inc.mk: fix "extraneous text after 'ifneq' directive" #18938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to compile `examples/hello-world` on my 465 MHz Mendocino I got /home/benpicco/dev/RIOT/makefiles/toolchain/gnu.inc.mk:29: extraneous text after 'ifneq' directive Turns out the version of `make` on Archlinux32 is newer than that in Ubuntu 22.04, which somehow ignored the extra parenthesis. Turns out this (t)rusty old machine is still good for writing patches :D
github-actions
bot
added
Area: build system
benpicco
added
Type: bug
benpicco
added
the
CI: ready for build
maribu
approved these changes
Nov 20, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
makeon Arch rightfully complains about the extra parenthesisIt's the same version that Ubuntu ships, but for some reason that just silently ignores it.It's also there on Ubuntu, I just didn't see it because it scrolled away so fast.
Testing procedure
Issues/PRs references
follow-up to #18935