boards/common/nrf52: fix timer config #18948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `channels` member should not be set to the number of hardware channels *n*, but to *n* - 1 instead. The last channel is implicitly used in `timer_read()`. Hence out of *n* hardware channels, only *n* - 1 are available to the application. This fixes a bug introduced by 4d02e15 which incorrectly set the channel number to *n* rather than to *n* - 1.
maribu
added
Type: bug
better add a comment to prevent this mistake in the future |
github-actions
bot
added
Area: cpu
benpicco
approved these changes
Nov 22, 2022
|
Thx :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The
channelsmember should not be set to the number of hardware channels n, but to n - 1 instead. The last channel is implicitly used intimer_read(). Hence out of n hardware channels, only n - 1 are available to the application.This fixes a bug introduced by 4d02e15 which incorrectly set the channel number to n rather than to n - 1.
Testing procedure
timer_read()should work again on nRF52 MCUs.Issues/PRs references
Introduced in #18811