pkg: paho-mqtt: added missing requirement #18997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paho won't compile on platforms where an Integer is smaller than 32 bit.
github-actions
bot
added
Area: network
OlegHahm
added
Type: bug
benpicco
approved these changes
Nov 30, 2022
bors bot
added a commit
that referenced
this pull request
Dec 11, 2022
18962: pkg/lwip: Force loglevel when using log module r=maribu a=yarrick 18999: Paho: Allow building for 8 and 16 bit platforms r=maribu a=OlegHahm ### Contribution description Providing a patch to Paho upstream which uses fixed size integers (int32_t) instead of plain int whenever it is used to represent a size of an object. This patch will allow to build the Paho package for platforms where an integer has a width of less than 32 bit. This patch is also provided as a PR to the upstream version of Paho (eclipse-paho/paho.mqtt.embedded-c#238) but unfortunately the upstream seems to be unmaintained. ### Testing procedure Build for a 8 or 16 bit platform that has enough memory for the example, e.g., https://api.riot-os.org/group__boards__atxmega-a1u-xpro.html: BUILD_IN_DOCKER=1 BOARD=atxmega-a1u-xpro make clean all Without this PR this build will fail, with the patches applied it will succeed. ### Issues/PRs references This PR makes #18997 obsolete and thus reverts the change. 19034: boards/nucleo-l496zg: doc improvement r=maribu a=krzysztof-cabaj ### Contribution description This PR adds to nucleo-l496zg documentation MCU table - similar to those, for example for, Nucleo F103RB, F302R8 or F446RE. ### Testing procedure ``` make doc xdg-open doc/doxygen/html/group__boards__nucleo-l496zg.html ``` ### Issues/PRs references None Co-authored-by: Erik Ekman <eekman@google.com> Co-authored-by: Oleg Hahm <oleg@hobbykeller.org> Co-authored-by: krzysztof-cabaj <kcabaj@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paho won't compile on platforms where an Integer is smaller than 32 bit.
Contribution description
This PR adds the corresponding requirement to the package.
Testing procedure
Build paho_mqtt example application and check if it still building for a 32 bit platform. (It won't build for a 16 bit platform even without this PR because of LWIP having the same requirement.)
Take a look at https://github.com/eclipse/paho.mqtt.embedded-c/blob/master/MQTTPacket/src/MQTTPacket.c#L93
Issues/PRs references
#18982 relies on this PR.