Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sam0_common: use size_t len for I2C transfers (fixes #19008) [backport 2022.10] #19019

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions cpu/sam0_common/periph/i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@
#endif

static int _start(SercomI2cm *dev, uint16_t addr);
static inline int _write(SercomI2cm *dev, const uint8_t *data, int length,
static inline int _write(SercomI2cm *dev, const uint8_t *data, size_t length,
uint8_t stop);
static inline int _read(SercomI2cm *dev, uint8_t *data, int length,
static inline int _read(SercomI2cm *dev, uint8_t *data, size_t length,
uint8_t stop);
static inline void _stop(SercomI2cm *dev);
static inline int _wait_for_response(SercomI2cm *dev,
Expand Down Expand Up @@ -373,10 +373,10 @@ static int _start(SercomI2cm *dev, uint16_t addr)
return 0;
}

static inline int _write(SercomI2cm *dev, const uint8_t *data, int length,
static inline int _write(SercomI2cm *dev, const uint8_t *data, size_t length,
uint8_t stop)
{
uint8_t count = 0;
size_t count = 0;

/* Write data buffer until the end. */
DEBUG("Looping through bytes\n");
Expand Down Expand Up @@ -413,10 +413,10 @@ static inline int _write(SercomI2cm *dev, const uint8_t *data, int length,
return 0;
}

static inline int _read(SercomI2cm *dev, uint8_t *data, int length,
static inline int _read(SercomI2cm *dev, uint8_t *data, size_t length,
uint8_t stop)
{
uint8_t count = 0;
size_t count = 0;

/* Set action to ack. */
dev->CTRLB.reg &= ~SERCOM_I2CM_CTRLB_ACKACT;
Expand Down